Skip to content

Added warning to Fermi detector angle calculation code, for when time returned is different from time requested#128

Merged
nabobalis merged 5 commits into
sunpy:mainfrom
aringlis:fermi_angle_fix
Aug 22, 2024
Merged

Added warning to Fermi detector angle calculation code, for when time returned is different from time requested#128
nabobalis merged 5 commits into
sunpy:mainfrom
aringlis:fermi_angle_fix

Conversation

@aringlis
Copy link
Copy Markdown
Member

In the fermi module of sunkit-instruments, the code get_detector_sun_angles_for_time returns the angle with respect to the Sun of each Fermi/GBM detector. This is done by reading in a Fermi spacecraft weekly file.

However, these files contain gaps due to the South Atlantic Anomaly. If the time requested falls in one of these gaps, the code will return the detector angles for the next available time. This can be several minutes different from the time requested. Currently, the code does not provide any indication that this has happened.

This PR adds a warning to the user if the time returned by the code is more than 1 minute different from the time requested (1 minute is the nominal cadence of the spacecraft weekly file), and explains that this is likely due to a South Atlantic Anomaly encounter.

Comment thread setup.cfg Outdated
Comment thread setup.cfg Outdated
@nabobalis nabobalis merged commit 542463f into sunpy:main Aug 22, 2024
@nabobalis
Copy link
Copy Markdown
Member

Thanks again @aringlis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants