Skip to content

Conversation

@avallete
Copy link
Member

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

Comment on lines 306 to 307
schema:
type: string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here had to replace the type from v1-yaml from uuid to string

enum:
- abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ:0123456789
- abcdefghijklmnopqrstuvwxyz:ABCDEFGHIJKLMNOPQRSTUVWXYZ:0123456789
- abcdefghijklmnopqrstuvwxyz:ABCDEFGHIJKLMNOPQRSTUVWXYZ:0123456789:!@#$%^&*()_+-=[]{};'\\:\"|<>?,./`~
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here had to replace what was generated on v1-yaml by this

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 12001912209

Details

  • 8 of 14 (57.14%) changed or added relevant lines in 7 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/bootstrap/bootstrap.go 0 1 0.0%
internal/projects/create/create.go 2 4 50.0%
cmd/projects.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11907080297: -0.03%
Covered Lines: 6381
Relevant Lines: 10720

💛 - Coveralls

@avallete avallete marked this pull request as ready for review November 22, 2024 12:35
@sweatybridge sweatybridge enabled auto-merge (squash) November 25, 2024 02:11
@sweatybridge sweatybridge merged commit 47bcb30 into develop Nov 25, 2024
12 checks passed
@sweatybridge sweatybridge deleted the avallete/chore-use-staging-api-beta-v1-yaml branch November 25, 2024 02:12
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants