Skip to content

fix: wait for started services to be healthy#770

Merged
sweatybridge merged 5 commits intomainfrom
wait-health
Jan 6, 2023
Merged

fix: wait for started services to be healthy#770
sweatybridge merged 5 commits intomainfrom
wait-health

Conversation

@sweatybridge
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Bug fix #146

What is the current behavior?

many containers are missing health checks

What is the new behavior?

add health checks for all services
prefer docker health check over http

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 6, 2023 08:44
@sweatybridge sweatybridge merged commit ee27286 into main Jan 6, 2023
@sweatybridge sweatybridge deleted the wait-health branch January 6, 2023 09:59
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2023

🎉 This PR is included in version 1.29.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3854274739

  • 82 of 88 (93.18%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 62.799%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/start/start.go 69 75 92.0%
Totals Coverage Status
Change from base Build 3853682600: 0.4%
Covered Lines: 3545
Relevant Lines: 5645

💛 - Coveralls

zlotnika pushed a commit to zlotnika/cli that referenced this pull request Apr 3, 2026
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait for services to be healthy on supabase start and supabase db reset

3 participants