Skip to content

Expose installed Supabase CLI version via output#170

Merged
sweatybridge merged 1 commit intosupabase:mainfrom
mikroskeem:feature/export-cli-version
May 17, 2023
Merged

Expose installed Supabase CLI version via output#170
sweatybridge merged 1 commit intosupabase:mainfrom
mikroskeem:feature/export-cli-version

Conversation

@mikroskeem
Copy link
Copy Markdown
Contributor

@mikroskeem mikroskeem commented May 17, 2023

What kind of change does this PR introduce?

Expose installed Supabase CLI version via action output.

What is the current behavior?

Installed CLI version is not available easily

What is the new behavior?

Installed CLI version is exposed via action output

Additional context

This is useful when setup-cli action is configured to install latest version, but following steps need to know what version was actually installed (for example, to implement Docker image caching to speed up test environment launching).

Will squash commits before merge.

@sweatybridge
Copy link
Copy Markdown
Collaborator

Instead of resolving the version from url redirect, how about running supabase -v in a subprocess after extracting the tarball? That would reflect the version actually installed into path.

@mikroskeem
Copy link
Copy Markdown
Contributor Author

Actually yes, that would yield the most reliable version output.

@mikroskeem mikroskeem force-pushed the feature/export-cli-version branch 2 times, most recently from a1b7b60 to 0a1ee01 Compare May 17, 2023 10:45
@mikroskeem mikroskeem changed the title Resolve & expose installed Supabase CLI version via output Expose installed Supabase CLI version via output May 17, 2023
@mikroskeem mikroskeem force-pushed the feature/export-cli-version branch from 0a1ee01 to 1fdcda6 Compare May 17, 2023 10:47
@mikroskeem
Copy link
Copy Markdown
Contributor Author

Reimplemented this via executing supabase --version after unpacking the CLI.

Copy link
Copy Markdown
Collaborator

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for the contribution.

@sweatybridge sweatybridge merged commit 8b3b75e into supabase:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants