Skip to content

Correct combined access policy logic #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisb2244 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Correct combined access policy logic #136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d18d62
Correct combined access policy logic
chrisb2244 Nov 3, 2025
f7ba62c
Fix typo
chrisb2244 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/0006_multiple_permissive_policies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ create policy grade_level_access on employee_data
using (grade_level <= current_user_grade_level());
```

The implementation contains a logic error. As written, every employee can see `employee_data` for every other employee within their departemnt. Similarly, every employee can see every other employee's data at or below their own grade level.
The implementation contains a logic error. As written, every employee can see `employee_data` for every other employee within their department. Similarly, every employee can see every other employee's data at or below their own grade level.

To address this issue, we can combine the two policies.

Expand All @@ -54,7 +54,7 @@ create policy consolidated_access on employee_data
for select
using (
department = current_user_department()
or grade_level >= current_user_grade_level()
and grade_level <= current_user_grade_level()
);
```

Expand Down