You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your solution for the "Right Side View" problem is correct and follows the standard BFS approach. Well done! However, there are a few areas for improvement:
Efficiency of Queue Operations: You are using a list for the queue and performing pop(0) which is an O(n) operation. This makes your solution less efficient for large trees. Instead, you should use collections.deque which allows O(1) popleft operations. Here's how you can modify your code:
Variable Naming: While short variable names are convenient, using more descriptive names can make your code easier to understand. For example, q could be renamed to queue, s to level_size, and curr to current_node.
Edge Handling: You correctly handle the case when the root is None. That's good!
Unnecessary Code: The solution is concise and to the point. There is no unnecessary code.
For the "Cousins in Binary Tree" solution, note that it was not required for this problem. However, if you are submitting multiple solutions, ensure they are in separate files and named appropriately.
Keep up the good work! With a small change to use deque, your solution will be efficient and optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.