Skip to content

Solved LL2 Problems#1413

Open
aahiawasthee wants to merge 1 commit intosuper30admin:masterfrom
aahiawasthee:master
Open

Solved LL2 Problems#1413
aahiawasthee wants to merge 1 commit intosuper30admin:masterfrom
aahiawasthee:master

Conversation

@aahiawasthee
Copy link
Copy Markdown

No description provided.

@super30admin
Copy link
Copy Markdown
Owner

Strengths:

  • The student demonstrates a strong understanding of data structures and algorithms.
  • The code is clean, well-commented, and follows good practices.
  • The solutions are efficient and correctly implement the required functionalities.

Areas for Improvement:

  • For the BSTIterator, the student could mention that the dfs method is a helper function for initializing the stack with the leftmost path, which would make the code even more self-explanatory.
  • In the intersection-of-ll solution, the variable names could be more descriptive (e.g., lenA and lenB could be lengthA and lengthB for clarity).
  • The reorder-list solution is excellent, but the comment "merge the two" could be expanded to explain the merging process in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants