Skip to content

feat: add support for custom vector shape#1773

Closed
VladaHarbour wants to merge 2 commits intomainfrom
sd-1499_custom-shapes
Closed

feat: add support for custom vector shape#1773
VladaHarbour wants to merge 2 commits intomainfrom
sd-1499_custom-shapes

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

@VladaHarbour VladaHarbour commented Jan 18, 2026

Before:
Screenshot 2026-02-13 at 15 37 29
After:
Screenshot 2026-02-13 at 15 34 12

@VladaHarbour VladaHarbour self-assigned this Jan 18, 2026
@linear
Copy link
Copy Markdown

linear Bot commented Jan 18, 2026

@github-actions
Copy link
Copy Markdown
Contributor

Visual diffs detected

Pixel differences were found in visual tests. This is not blocking — reproduce locally with cd tests/visual && pnpm docs:download && pnpm test to review diffs.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ AI Risk Review — potential issues found

  • SVG path commands from DOCX are not validated - only structural checks on the geometry object, allowing potentially malicious or malformed SVG commands
  • extractCustomGeometry() uses scaleX/scaleY but doesn't validate that intrinsicWPx/intrinsicHPx are positive before division, could divide by zero if EMU values are 0
  • deriveBlockVersion concatenates path strings without length limits, very complex paths could cause performance issues in cache key comparison

Via L3 deep analysis · sensitive risk

@caio-pizzol
Copy link
Copy Markdown
Contributor

@VladaHarbour thanks for the work on this! custom geometry support (a:custGeom) has since been implemented on main via #2105 (SD-1877) — extraction, rendering, and tests are all in place. closing as superseded.

@caio-pizzol caio-pizzol closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants