Skip to content

feat(comments): add position-ordered comments getter#1774

Merged
harbournick merged 1 commit intosuperdoc-dev:mainfrom
financialvice:feature/comments-by-position
Jan 21, 2026
Merged

feat(comments): add position-ordered comments getter#1774
harbournick merged 1 commit intosuperdoc-dev:mainfrom
financialvice:feature/comments-by-position

Conversation

@financialvice
Copy link
Copy Markdown
Contributor

@financialvice financialvice commented Jan 19, 2026

Adds a position-sorted comments getter with tests.
Tests: pnpm -C packages/superdoc test -- comments-store.test.js

Copy link
Copy Markdown
Collaborator

@harbournick harbournick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - adding some more tests and JSdoc in separate commit
Thanks for contributing @financialvice!

@harbournick harbournick merged commit bdac914 into superdoc-dev:main Jan 21, 2026
harbournick pushed a commit that referenced this pull request Jan 21, 2026
# [1.8.0-next.7](v1.8.0-next.6...v1.8.0-next.7) (2026-01-21)

### Bug Fixes

* **search:** preserve leading/trailing whitespace in flexible matches ([#1788](#1788)) ([c5d6751](c5d6751))

### Features

* comment anchor helpers ([#1796](#1796)) ([595bdc6](595bdc6))
* comment highlight config ([#1798](#1798)) ([aa7e957](aa7e957))
* **comments:** add position-ordered comments getter ([#1774](#1774)) ([bdac914](bdac914))
@harbournick
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.8.0-next.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

harbournick pushed a commit that referenced this pull request Jan 21, 2026
# [1.8.0](v1.7.0...v1.8.0) (2026-01-21)

### Bug Fixes

* add addToHistory to new insertTrackedChange command ([#1767](#1767)) ([e5081be](e5081be))
* annotation drop ([#1789](#1789)) ([f384213](f384213))
* annotation selection ([#1762](#1762)) ([1c831cc](1c831cc))
* annotation selection, applying formatting ([#1784](#1784)) ([924af4b](924af4b))
* guard against null editor ref in telemetry handler ([#1763](#1763)) ([16b3a9a](16b3a9a))
* **layout:** default missing lineRule to auto for OOXML line spacing ([d0fd582](d0fd582))
* preserve nested comment ranges on export (SD-1518) ([#1765](#1765)) ([9b81f9a](9b81f9a))
* reorganize style resolution in the layout engine (SD-1411) ([#1786](#1786)) ([1845b76](1845b76))
* **search:** preserve leading/trailing whitespace in flexible matches ([#1788](#1788)) ([c5d6751](c5d6751))
* trigger release ([f826636](f826636))

### Features

* add insertTrackedChange programmatic shortcut ([#1761](#1761)) ([cd0628e](cd0628e))
* add visual indication for tracked change, comments and nested comments ([#1770](#1770)) ([8eb07e4](8eb07e4))
* comment anchor helpers ([#1796](#1796)) ([595bdc6](595bdc6))
* comment highlight config ([#1798](#1798)) ([aa7e957](aa7e957))
* **comments:** add position-ordered comments getter ([#1774](#1774)) ([bdac914](bdac914))
* include non-breaking spaces in search ([#1768](#1768)) ([d2784b9](d2784b9))
* search cross block anchor ([#1799](#1799)) ([09efa63](09efa63))
* view options print and web ([#1793](#1793)) ([82adcb1](82adcb1))
@harbournick
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants