IT-260 - fix: sync presentationEditor with hidden host#1856
IT-260 - fix: sync presentationEditor with hidden host#1856harbournick merged 10 commits intomainfrom
Conversation
…587) (#1806) * fix: remove dead code * refactor: table and paragraph converters to avoid redirection * test: adjust existing tests * fix: remove unused imports and dead code * fix: pass theme colors to node handlers * refactor: simplify type definitions for converters --------- Co-authored-by: Luccas Correa <luccas@superdoc.dev>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 213ec6def1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Hi @harbournick @artem-harbour @afn, when you have a chance I'd appreciate your eyes on this! This allows ProseMirror plugin decorations (like highlights) to appear in the presentationEditor by syncing decoration attributes from the hidden host to the painter host. |
|
@harbournick @artem-harbour @afn putting into draft until perf. optimizations made. |
mattConnHarbour
force-pushed
the
IT-260
branch
from
213ec6d to
bd67485
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd674854b7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
mattConnHarbour
force-pushed
the
IT-260
branch
from
bd67485 to
e26e967
Compare
|
@nick adding an example custom plugin to this PR for better tests. |
Visual diffs detectedPixel differences were found in visual tests. This is not blocking — reproduce locally with |
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
Hey @mattConnHarbour!
Great start! I noticed two things that seem to be blockers for me but please take another look:
1. Stale highlights - sync adds classes but never removes them. When a highlight is cleared, the old classes stay on the DOM.
2. Sync doesn't fire for decoration-only transactions - setMeta transactions don't trigger a repaint, so #syncDecorationAttributes never runs. Could hook into the transaction event instead of update since it fires for everything.
|
🎉 This PR is included in superdoc v1.15.0-next.14 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.15.0 The release is available on GitHub release |
|
🎉 This PR is included in superdoc-cli v0.2.0 The release is available on GitHub release |
5 participants
No description provided.