fix: ensure we do not duplicate bubble text#1934
Conversation
palmer-cl
commented
Feb 4, 2026
palmer-cl
commented
- The document nodes are the source of truth for what appears in the editor, so they should define the comment text.
- Also keep the fallbacks
- added tests
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
clean one @palmer-cl!
the only addition I would say here is that in this case, it also impacts rendering and interactions with the editor. we should definitely write interaction stories and upload a sample file for visual testing.
packages/super-editor/src/extensions/comment/comments-plugin.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/extensions/comment/comments-plugin.js
Outdated
Show resolved
Hide resolved
|
@caio-pizzol added VRTs and updated comments. |
| // safety net for identity dedupe | ||
| // work is done above |
There was a problem hiding this comment.
I think the previous comment ("Remove duplicates by comparing node identity") was clearer
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
LGTM -
Missing behavior tests - I will add them later
caio-pizzol
deleted the
colep/sd-1739-bug-tracked-changes-replacements-duplicate-last-character
branch
|
@caio-pizzol dont the VRT screenshot tests have the behavior embedded in them? we have to perform the user actions before taking the screenshot? |
|
🎉 This PR is included in superdoc v1.13.0-next.2 The release is available on GitHub release |
behavior test added here: 9a6385f |
# [1.13.0](v1.12.0...v1.13.0) (2026-02-14) ### Bug Fixes * anchor table overlaps text ([#1995](#1995)) ([fc05e29](fc05e29)) * collaboration cursor styles fix ([fd6db10](fd6db10)) * ensure we do not duplicate bubble text ([#1934](#1934)) ([c41cf9e](c41cf9e)) * ignore sdBlockId when pasting content ([#2010](#2010)) ([1b08572](1b08572)) * normalize bookmarks in tables ([#1892](#1892)) ([369b7e1](369b7e1)) * replace Node.js Buffer APIs with browser-native alternatives ([#2028](#2028)) ([b17774a](b17774a)), closes [#exportProcessMediaFiles](https://github.com/superdoc-dev/superdoc/issues/exportProcessMediaFiles) * use correct template syntax for GitHub release URL in PR comments ([9d1bca2](9d1bca2)) ### Features * enabled telemetry by default and added documentation ([#2001](#2001)) ([8598ef7](8598ef7)) * enhance telemetry handling for sub-editors ([#2017](#2017)) ([37bc030](37bc030)) * update telemetry configuration to prioritize root licenseKey ([#2016](#2016)) ([3b4ff6b](3b4ff6b))
|
🎉 This PR is included in superdoc v1.13.0 The release is available on GitHub release |
4 participants
