Skip to content

fix: zIndex updates #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 2 commits into from
Feb 9, 2026
Merged

fix: zIndex updates #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14cecaa
fix: zIndex updates
VladaHarbour Feb 9, 2026
cdc6f91
fix: revert behindDoc change
VladaHarbour Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/layout-engine/painters/dom/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3951,7 +3951,8 @@ export class DomPainter {
img.style.marginRight = `${run.distRight}px`;
}

// Apply z-index to render above tab leaders
// Position and z-index on the image only (not the line) so resize overlay can stack above.
img.style.position = 'relative';
img.style.zIndex = '1';

// Assert PM positions are present for cursor fallback
Expand Down Expand Up @@ -4282,6 +4283,9 @@ export class DomPainter {
throw new Error('DomPainter: document is not available');
}

const lineRange = computeLinePmRange(block, line);
let runsForLine = sliceRunsForLine(block, line);

const el = this.doc.createElement('div');
el.classList.add(CLASS_NAMES.line);
applyStyles(el, lineStyles(line.lineHeight));
Expand All @@ -4301,16 +4305,12 @@ export class DomPainter {
el.style.textAlign = 'left';
}

const lineRange = computeLinePmRange(block, line);

if (lineRange.pmStart != null) {
el.dataset.pmStart = String(lineRange.pmStart);
}
if (lineRange.pmEnd != null) {
el.dataset.pmEnd = String(lineRange.pmEnd);
}

let runsForLine = sliceRunsForLine(block, line);
const trackedConfig = this.resolveTrackedChangesConfig(block);

// Preserve PM positions for DOM caret mapping on empty lines.
Expand Down
10 changes: 3 additions & 7 deletions packages/layout-engine/painters/dom/src/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,10 @@ export const fragmentStyles: Partial<CSSStyleDeclaration> = {
};

/**
* Z-index for paragraph text lines, ensuring they render above floating
* OOXML-derived fragments (which typically range 1–10 000). Must stay
* below browser-UI layers (tooltips, menus, overlays) that may live in the
* same stacking context.
* Line container styles. z-index is intentionally not set on the line so that
* the resize overlay (and other UI) can stack above content. Only the image
* element itself gets z-index for layering within the line (e.g. above tab leaders).
*/
const TEXT_LINE_Z_INDEX = '100000';

export const lineStyles = (lineHeight: number): Partial<CSSStyleDeclaration> => ({
lineHeight: `${lineHeight}px`,
height: `${lineHeight}px`,
Expand All @@ -95,7 +92,6 @@ export const lineStyles = (lineHeight: number): Partial<CSSStyleDeclaration> =>
// provides defense-in-depth against any remaining sub-pixel rendering
// differences between measurement and display.
overflow: 'visible',
zIndex: TEXT_LINE_Z_INDEX,
});

const PRINT_STYLES = `
Expand Down
Loading