Skip to content

fix: preserve text selection highlight on right-click #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caio-pizzol merged 2 commits into from
Feb 11, 2026
Merged

fix: preserve text selection highlight on right-click #1994

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a330ed
fix: preserve text selection highlight on right-click
henriquedevelops Feb 11, 2026
b0c7f65
Update packages/super-editor/src/core/presentation-editor/Presentatio…
henriquedevelops Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/super-editor/src/core/presentation-editor/PresentationEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { NodeSelection, Selection, TextSelection } from 'prosemirror-state';
import { SlashMenuPluginKey } from '@extensions/slash-menu/slash-menu.js';
import { CellSelection } from 'prosemirror-tables';
import type { EditorState, Transaction } from 'prosemirror-state';
import type { Node as ProseMirrorNode, Mark } from 'prosemirror-model';
Expand Down Expand Up @@ -3367,8 +3368,10 @@ export class PresentationEditor extends EventEmitter {

const activeEditor = this.getActiveEditor();
const hasFocus = activeEditor?.view?.hasFocus?.() ?? false;
// Keep selection visible when context menu (SlashMenu) is open
const slashMenuOpen = activeEditor?.state ? !!SlashMenuPluginKey.getState(activeEditor.state)?.open : false;

if (!hasFocus) {
if (!hasFocus && !slashMenuOpen) {
try {
this.#clearSelectedFieldAnnotationClass();
this.#localSelectionLayer.innerHTML = '';
Expand Down
Loading