-
Notifications
You must be signed in to change notification settings - Fork 68
perf(build): migrate to rolldown-vite for ~2x faster builds #2006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
perf(build): migrate to rolldown-vite for ~2x faster builds #2006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9705bbc90e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Replace regex alias with explicit list in ai vitest config - Add maintenance comment to superdocSrcAliases list - Add explanation comment for readable-stream patch
|
@caio-pizzol this seems to break pnpm dev for me. can you double check if anything else is needed here? |
… rolldown Add 'index.js' to the explicit superdocSrcAliases list so rolldown can resolve @superdoc/index.js (regex capture groups aren't supported). Add a resolve plugin in optimizeDeps to handle 'punycode/' trailing-slash imports from node-stdlib-browser's url polyfill — rolldown treats these as directory paths instead of package entry points. Replace deprecated esbuildOptions with rollupOptions for rolldown-vite.
…vite-build-to-rolldown-vite-for-faster-bundling # Conflicts: # pnpm-lock.yaml
GTG now! |
Visual diffs detectedPixel differences were found in visual tests. This is not blocking — reproduce locally with |
https://vite.dev/guide/rolldown