Skip to content

Conversation

@caio-pizzol
Copy link
Contributor

@caio-pizzol caio-pizzol commented Feb 12, 2026

@linear
Copy link

linear bot commented Feb 12, 2026

@caio-pizzol caio-pizzol requested review from afn, artem-harbour and harbournick and removed request for harbournick February 12, 2026 09:55
@caio-pizzol caio-pizzol self-assigned this Feb 12, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9705bbc90e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- Replace regex alias with explicit list in ai vitest config
- Add maintenance comment to superdocSrcAliases list
- Add explanation comment for readable-stream patch
@harbournick
Copy link
Collaborator

@caio-pizzol this seems to break pnpm dev for me. can you double check if anything else is needed here?

… rolldown

Add 'index.js' to the explicit superdocSrcAliases list so rolldown can
resolve @superdoc/index.js (regex capture groups aren't supported).

Add a resolve plugin in optimizeDeps to handle 'punycode/' trailing-slash
imports from node-stdlib-browser's url polyfill — rolldown treats these
as directory paths instead of package entry points.

Replace deprecated esbuildOptions with rollupOptions for rolldown-vite.
…vite-build-to-rolldown-vite-for-faster-bundling

# Conflicts:
#	pnpm-lock.yaml
@caio-pizzol
Copy link
Contributor Author

@caio-pizzol this seems to break pnpm dev for me. can you double check if anything else is needed here?

GTG now! polyfill old ESbuild syntax 😓

@github-actions
Copy link
Contributor

Visual diffs detected

Pixel differences were found in visual tests. This is not blocking — reproduce locally with cd tests/visual && pnpm docs:download && pnpm test to review diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants