Skip to content

fix: import regression #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 1 commit into from
Mar 18, 2026
Merged

fix: import regression #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ const findSectPr = (obj, result = []) => {
if (obj && obj.name === 'w:sectPr') {
result.push(obj);
}
if (obj.elements) {
if (obj && obj.elements) {
obj.elements.forEach((el) => findSectPr(el, result));
}
return result;
Expand Down
27 changes: 27 additions & 0 deletions packages/super-editor/src/tests/import/docxImporter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,33 @@ describe('addDefaultStylesIfMissing', () => {
});

describe('createDocumentJson', () => {
it('falls back to default document XML and base numbering when document.xml is missing', () => {
const docx = {};

const converter = {
headers: {},
footers: {},
headerIds: {},
footerIds: {},
docHiglightColors: new Set(),
};

const editor = { options: {}, emit: vi.fn() };

const result = createDocumentJson(docx, converter, editor);

expect(result).toBeTruthy();
expect(result.pmDoc?.type).toBe('doc');
expect(result.pageStyles.pageMargins.left).toBeCloseTo(1);
expect(result.pageStyles.pageSize.width).toBeCloseTo(8.5);
expect(Object.keys(result.numbering.definitions || {})).not.toHaveLength(0);
expect(Object.keys(result.numbering.abstracts || {})).not.toHaveLength(0);
expect(Object.keys(result.translatedNumbering.definitions || {})).not.toHaveLength(0);
expect(Object.keys(result.translatedNumbering.abstracts || {})).not.toHaveLength(0);
expect(converter.headers).toEqual({});
expect(converter.footers).toEqual({});
});

it('handles missing document relationships gracefully', () => {
const simpleDocXml =
'<w:document xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main"><w:body><w:p><w:r><w:t>Hello</w:t></w:r></w:p></w:body></w:document>';
Expand Down
Loading