Skip to content

fix(tables): prevent resize overlay artifacts during drag #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harbournick merged 2 commits into from
Mar 19, 2026
Merged

fix(tables): prevent resize overlay artifacts during drag #2479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
609acf6
fix(tables): prevent resize overlay artifacts during drag
harbournick Mar 19, 2026
0569456
fix(tables): prevent stuck resize drag when pointer leaves window
harbournick Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/super-editor/src/components/SuperEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ const openPopover = (component, props, position) => {
const tableResizeState = reactive({
visible: false,
tableElement: null,
dragging: false,
});

/**
Expand Down Expand Up @@ -553,6 +554,9 @@ const isNearRowBoundary = (event, tableElement) => {
* @returns {void}
*/
const updateTableResizeOverlay = (event) => {
// Don't change overlay visibility while a resize drag is active
if (tableResizeState.dragging) return;

// Throttle: skip if called too frequently
const now = Date.now();
if (now - lastUpdateTableResizeTimestamp < TABLE_RESIZE_THROTTLE_MS) {
Expand Down Expand Up @@ -594,6 +598,17 @@ const updateTableResizeOverlay = (event) => {
* Hide table resize overlay (on mouse leave)
*/
const hideTableResizeOverlay = () => {
if (tableResizeState.dragging) return;
Comment thread
harbournick marked this conversation as resolved.
tableResizeState.visible = false;
tableResizeState.tableElement = null;
};

const onTableResizeStart = () => {
tableResizeState.dragging = true;
};

const onTableResizeEnd = () => {
tableResizeState.dragging = false;
tableResizeState.visible = false;
tableResizeState.tableElement = null;
};
Expand Down Expand Up @@ -735,7 +750,12 @@ const handleOverlayUpdates = (event) => {
} else {
updateTableResizeOverlay(event);
}
updateImageResizeOverlay(event);
// Don't evaluate image overlay during an active table resize drag —
// without the oversized table overlay, pointer events can reach images
// and spuriously activate the image resize overlay mid-drag.
if (!tableResizeState.dragging) {
updateImageResizeOverlay(event);
}
};

/**
Expand Down Expand Up @@ -1207,6 +1227,8 @@ onBeforeUnmount(() => {
:editor="activeEditor"
:visible="tableResizeState.visible"
:tableElement="tableResizeState.tableElement"
@resize-start="onTableResizeStart"
@resize-end="onTableResizeEnd"
/>
<!-- Image resize overlay for interactive image resizing -->
<ImageResizeOverlay
Expand Down
Loading
Loading