fix(super-converter): add null guards to decodeRPrFromMarks (SD-2023)#2638
Closed
caio-pizzol wants to merge 2 commits intomainfrom
Closed
fix(super-converter): add null guards to decodeRPrFromMarks (SD-2023)#2638caio-pizzol wants to merge 2 commits intomainfrom
caio-pizzol wants to merge 2 commits intomainfrom
Conversation
…e marks Tracked format snapshots can contain sparse marks (missing attrs) or null entries. Without guards, mark.type.name and mark.attrs throw.
superdoc-bot
Bot
added
review: thorough
review: careful
and removed
review: thorough
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked format snapshots can contain sparse marks (missing
attrs) or null entries in the marks array. Without guards,mark.type.nameandmark.attrsthrow on these inputs.mark.attrsto{}for sparse marksmark.attrsreferences with the safeattrslocalFollows up on #2395 which fixed the core tracked formatting export bug but didn't include these defensive guards.
SD-2023