Closed
Conversation
nicopap
commented
Sep 19, 2023
nicopap
commented
Sep 19, 2023
superdump
requested changes
Sep 19, 2023
Owner
superdump
left a comment
There was a problem hiding this comment.
Very nice improvements! Thanks!
Just a couple of comments to address.
Author
|
Well, for some reasons my new commits do not show up in the Github UI. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueryItem<Self::Query>instead of<Self::Query as WorldQuery>::Item<'_>(I think I might have missed some instancesPartialEqderive over manual implreduceover a fairly complex loop setup inbatch_and_prepare_render_phaseBatchMetafrombatch_and_prepare_render_phasetoBatchMeta::newBatchMetafields private.render_rangeinrenderinstead of copy/pasting the code.Replace the odd handling of arrays inSetMesh2dBindGroup::render