Mention WASI flag as note only #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freaz
force-pushed
the
doc/wasi_preview1_is_enabled_by_default
branch
2 times, most recently
from
346e387 to
d124c8b
Compare
freaz
force-pushed
the
doc/wasi_preview1_is_enabled_by_default
branch
from
d124c8b to
f9d8a0a
Compare
martyndavies
approved these changes
Aug 21, 2023
martyndavies
left a comment
martyndavies
left a comment
There was a problem hiding this comment.
LGTM - good to include, and yes, less scary!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs/node#47286
WASI preview1 is enabled since node 18.17 and in node 20 be default.
This PR changes it to mention need for flag as note instead having it as mandatory.
I think this makes it less scary for use not familiar with WebAssembly and WASI.