Add pg-major-version flag to mpg create
#4701
Conversation
Allows us to create PG17 deployments using `flyctl` Signed-off-by: Akshit Garg <akshit@fly.io>
There was a problem hiding this comment.
Pull request overview
This PR adds support for specifying the Postgres major version when creating a managed Postgres cluster via the fly mpg create command. The implementation allows users to choose between Postgres 16 and 17, with 16 as the default.
- Added
--pg-major-versionflag to thempg createcommand with validation - Extended the
CreateClusterInputstruct to include the Postgres major version - Implemented validation logic to ensure only supported versions (16 and 17) are accepted
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/command/mpg/create.go | Added flag definition, validation logic, and parameter passing for Postgres major version selection |
| internal/uiex/managed_postgres.go | Extended CreateClusterInput struct with PGMajorVersion field for API communication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pgMajorVersion := flag.GetInt(ctx, "pg-major-version") | ||
| if pgMajorVersion != 16 && pgMajorVersion != 17 { | ||
| return fmt.Errorf("invalid Postgres major version: %d. Supported versions are 16 and 17", pgMajorVersion) | ||
| } |
There was a problem hiding this comment.
The validation logic for the Postgres major version should have test coverage. Consider adding a test case that verifies the validation rejects invalid versions (e.g., 15, 18) and accepts valid versions (16, 17). The existing test file mpg_test.go has similar validation tests for regions and other parameters.
Allows us to create PG17 deployments using
flyctl. It defaults to 16 for now.Example