Open
Conversation
- Implement validation to ensure snapshots contain all expected pages - Track lastPgno during page decoding - Add comprehensive tests for snapshot completeness validation - Handle special case where commit equals lock page number - Resolves TODO: Ensure last read page is equal to the commit for snapshot LTX files
44b7380 to
8c65988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
decoder.goto track the last page number read and validate it matches the expected value for snapshotsTestDecoder_SnapshotCompletenesswith four test cases:Implementation Details
The decoder now tracks
lastPgnoduring page reads and validates duringClose()that:This ensures snapshot files are complete and haven't been truncated or corrupted.
🤖 Generated with Claude Code