fix: return error on malformed hooks JSON instead of silent data loss#169
Merged
claude[bot] merged 1 commit intomainfrom Feb 27, 2026
Merged
fix: return error on malformed hooks JSON instead of silent data loss#169claude[bot] merged 1 commit intomainfrom
claude[bot] merged 1 commit intomainfrom
Conversation
When the hooks section of settings.json contains invalid JSON, return an error rather than silently resetting existingHooks to an empty map. This prevents Uncompact from overwriting the user's existing hooks with no warning. Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: claude[bot] <claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the hooks section of settings.json contains invalid JSON, Install now returns an error instead of silently resetting existingHooks to an empty map. This prevents Uncompact from overwriting the user's existing hooks with no warning.
Change
In internal/hooks/hooks.go (lines 136-138), replaced the silent reset with a proper error return.
Before: silently reset existingHooks to an empty map on parse error
After: return nil, fmt.Errorf("existing hooks section is not valid JSON: %w", err)
Closes #166
Generated with Claude Code