fix: check context cancellation inside filepath.Walk in RepoZip#235
Merged
claude[bot] merged 1 commit intomainfrom Feb 28, 2026
Merged
fix: check context cancellation inside filepath.Walk in RepoZip#235claude[bot] merged 1 commit intomainfrom
claude[bot] merged 1 commit intomainfrom
Conversation
RepoZip accepted a context but only used it for the git ls-files subprocess. The filepath.Walk ran to completion regardless of cancellation or timeout. Now the walk callback checks ctx.Done() at the top of each iteration and returns ctx.Err() immediately when the context is cancelled or timed out. Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: claude[bot] <claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select { case <-ctx.Done(): return ctx.Err() }guard at the top of thefilepath.Walkcallback ininternal/zip/zip.goRepoZippassed the context tobuildGitFileSetbut ignored it during the walk; the walk would run to completion even if the 10-minute timeout from the caller fired mid-walkFixes #232
Generated with Claude Code