feat: automate release pipeline and close the proactive→implement loop#25
Merged
greynewell merged 2 commits intomainfrom Feb 27, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
WalkthroughAdds CI workflows and goreleaser config: auto-generates semantic tags from commit messages, runs releases on tag pushes, and refines Claude-related workflows to detect/append Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant Repo as GitHub Repo
participant AutoTag as Action: Auto-Tag
participant GitHub as GitHub (API)
participant ReleaseWF as Action: Release
participant Goreleaser as Goreleaser
Dev->>Repo: push to main
Repo->>AutoTag: push event (main)
AutoTag->>Repo: fetch tags & commits
AutoTag->>AutoTag: parse latest tag and last commit message
AutoTag->>Repo: create annotated tag vMAJOR.MINOR.PATCH
AutoTag->>GitHub: push tag
GitHub->>ReleaseWF: tag push triggers release workflow
ReleaseWF->>Repo: checkout tag
ReleaseWF->>Goreleaser: invoke goreleaser release
Goreleaser->>GitHub: upload artifacts & create Release
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Add goreleaser config for cross-platform binary releases (linux/darwin/windows, amd64/arm64) - Add release.yml workflow: triggers goreleaser on v* tags - Add auto-tag.yml workflow: bumps semver on every main push (feat→minor, fix/other→patch, breaking→major) - Fix claude-proactive.yml: always end issue bodies with @claude so created issues get picked up - Fix claude-auto-assign.yml: also trigger for app/claude bot issues, skip if @claude already present - Update CLAUDE.md: document @claude requirement for issues and co-author requirement for commits Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
greynewell
force-pushed
the
claude/factory-improvements-20260227-0126
branch
from
58bed95 to
6030e5d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
CLAUDE.md (1)
22-24: Add a language specifier to the fenced code block.The linter is flagging this code block because it doesn't have a language specified. Even for plain text examples, adding something like
textormarkdownhelps with consistency and silences the warning.Think of it like this: if someone's editor has syntax highlighting, specifying the language (even
text) makes the intent clear.✏️ Suggested fix
-``` +```text `@claude` please implement this</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@CLAUDE.mdaround lines 22 - 24, Update the fenced code block in CLAUDE.md so
it includes a language specifier (e.g., change the openingtotext)
surrounding the "@claude please implement this" block; locate the
triple-backtick fence in the file and add the specifier to silence the linter
and make the intent explicit.</details> </blockquote></details> <details> <summary>.github/workflows/auto-tag.yml (1)</summary><blockquote> `39-45`: **Tag creation looks solid.** Using the GitHub Actions bot identity for commits/tags is the standard pattern. The tag push will trigger your release workflow since it matches `v*`. One thing to be aware of: if this workflow runs on a merge commit that already has a tag (like a re-run), it'll try to create a duplicate tag and fail. That's probably fine since the release would already exist, but if you want to be defensive: <details> <summary>🛡️ Optional: Skip if tag already exists</summary> ```diff NEW_TAG="v${MAJOR}.${MINOR}.${PATCH}" echo "New tag: $NEW_TAG" + # Skip if tag already exists + if git rev-parse "$NEW_TAG" >/dev/null 2>&1; then + echo "Tag $NEW_TAG already exists, skipping." + exit 0 + fi + git config user.name "github-actions[bot]" ``` </details> <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto-tag.yml around lines 39 - 45, Check whether the tag already exists before creating/pushing to avoid duplicate-tag failures: use the NEW_TAG variable and run a remote check like git ls-remote --tags origin "$NEW_TAG" (or git rev-parse --verify "refs/tags/$NEW_TAG") and only run git tag "$NEW_TAG" and git push origin "$NEW_TAG" when that check returns no match; if the tag exists, skip tagging/pushing and optionally echo a message. Ensure the conditional wraps the existing git tag and git push origin lines so the workflow is defensive against re-runs. ``` </details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/auto-tag.yml:
- Around line 22-27: The pipeline can produce an empty LATEST and the fallback
after the pipe won't run; ensure LATEST is non-empty before extracting MAJOR,
MINOR, and PATCH by assigning a default when empty (for example, use bash
parameter expansion or an explicit if/test to set LATEST to v0.0.0 if it is
empty), then derive MAJOR, MINOR, and PATCH from that guaranteed-nonempty LATEST
variable so you never end up with empty parts or a malformed tag.In @.github/workflows/claude-auto-assign.yml:
- Around line 29-30: The bot-detection logic in the isClaudeBot assignment is
too broad and uses a non-standard string; replace the current check (author ===
'app/claude' || author.startsWith('claude')) with an exact match against the
GitHub App bot name — e.g. author === 'claude[bot]' (and optionally author ===
'app/claude[bot]' if you want to be defensive) — or use a strict regex like
/^claude([bot])?$/ to avoid matching human usernames; update the isClaudeBot
variable accordingly.
Nitpick comments:
In @.github/workflows/auto-tag.yml:
- Around line 39-45: Check whether the tag already exists before
creating/pushing to avoid duplicate-tag failures: use the NEW_TAG variable and
run a remote check like git ls-remote --tags origin "$NEW_TAG" (or git rev-parse
--verify "refs/tags/$NEW_TAG") and only run git tag "$NEW_TAG" and git push
origin "$NEW_TAG" when that check returns no match; if the tag exists, skip
tagging/pushing and optionally echo a message. Ensure the conditional wraps the
existing git tag and git push origin lines so the workflow is defensive against
re-runs.In
@CLAUDE.md:
- Around line 22-24: Update the fenced code block in CLAUDE.md so it includes a
language specifier (e.g., change the openingtotext) surrounding the
"@claude please implement this" block; locate the triple-backtick fence in the
file and add the specifier to silence the linter and make the intent explicit.</details> --- <details> <summary>ℹ️ Review info</summary> **Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 0b0577225b854f625a8a09583be9a9ba67937592 and 58bed958ff3d8f55728785576c33a70db835a78f. </details> <details> <summary>📒 Files selected for processing (6)</summary> * `.github/workflows/auto-tag.yml` * `.github/workflows/claude-auto-assign.yml` * `.github/workflows/claude-proactive.yml` * `.github/workflows/release.yml` * `.goreleaser.yaml` * `CLAUDE.md` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
CLAUDE.md (1)
22-24: Minor: Add language specifiers to fenced code blocks.The linter is flagging these code blocks because they don't have a language tag. Even for plain text snippets, you can use
textorplaintextto make it explicit and quiet the warning.Think of it like: the linter doesn't know if you forgot to specify a language or if it's intentionally plain text, so it asks you to be explicit.
✏️ Suggested fix
-``` +```text `@claude` please implement thisAnd similarly for the co-author block: ```diff -``` +```text Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com></details> Also applies to: 37-40 <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against the current code and only fix it if needed.
In
@CLAUDE.mdaround lines 22 - 24, Add explicit language tags to the fenced
code blocks containing the literal snippet "@claude please implement this" and
the co-author lines "Co-Authored-By: Grey Newell greyshipscode@gmail.com" and
"Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com" by changing the
fences fromtotext (or ```plaintext) so the linter recognizes them as
plain text; update the code fences surrounding those exact strings to include
the language specifier.</details> </blockquote></details> <details> <summary>.github/workflows/auto-tag.yml (1)</summary><blockquote> `19-45`: **Consider adding `set -e` for safer script execution.** Right now, if any command fails (like the `git push`), the script just keeps going. Adding `set -e` at the top of the run block makes it exit immediately on any error, which is usually what you want for CI scripts. <details> <summary>✏️ Suggested addition</summary> ```diff - name: Bump version and tag run: | + set -e # Get latest semver tag, default to v0.0.0 ``` </details> <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against the current code and only fix it if needed. In @.github/workflows/auto-tag.yml around lines 19 - 45, The run block should exit on any failing command to avoid continuing after errors (e.g., failed git push); add a shell safety flag such as set -e (optionally set -o pipefail) at the top of the Bump version and tag run block so that the subsequent commands manipulating LATEST, MAJOR, MINOR, PATCH, MSG and creating/pushing NEW_TAG stop immediately on failure. ``` </details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/auto-tag.yml:
- Around line 44-45: The workflow currently runs git tag "$NEW_TAG" and git push
origin "$NEW_TAG" which will fail if the tag already exists; update the job to
first check for the tag and skip or handle it gracefully: test for a local tag
(git rev-parse --verify "refs/tags/$NEW_TAG") and for a remote tag (git
ls-remote --tags origin "$NEW_TAG") and only run git tag "$NEW_TAG" and git push
origin "$NEW_TAG" when not present, or explicitly decide to use git tag -f and
git push --force origin "$NEW_TAG" if overwriting is intended—ensure your change
references NEW_TAG, git tag and git push origin in the workflow so duplicate-tag
conditions are detected and reported clearly instead of causing an opaque
failure.
Nitpick comments:
In @.github/workflows/auto-tag.yml:
- Around line 19-45: The run block should exit on any failing command to avoid
continuing after errors (e.g., failed git push); add a shell safety flag such as
set -e (optionally set -o pipefail) at the top of the Bump version and tag run
block so that the subsequent commands manipulating LATEST, MAJOR, MINOR, PATCH,
MSG and creating/pushing NEW_TAG stop immediately on failure.In
@CLAUDE.md:
- Around line 22-24: Add explicit language tags to the fenced code blocks
containing the literal snippet "@claude please implement this" and the co-author
lines "Co-Authored-By: Grey Newell greyshipscode@gmail.com" and
"Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com" by changing the
fences fromtotext (or ```plaintext) so the linter recognizes them as
plain text; update the code fences surrounding those exact strings to include
the language specifier.</details> --- <details> <summary>ℹ️ Review info</summary> **Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 58bed958ff3d8f55728785576c33a70db835a78f and 6030e5dbb1d3436e5052f53af74d1d749c68e4a0. </details> <details> <summary>📒 Files selected for processing (6)</summary> * `.github/workflows/auto-tag.yml` * `.github/workflows/claude-auto-assign.yml` * `.github/workflows/claude-proactive.yml` * `.github/workflows/release.yml` * `.goreleaser.yaml` * `CLAUDE.md` </details> <details> <summary>🚧 Files skipped from review as they are similar to previous changes (2)</summary> * .github/workflows/release.yml * .goreleaser.yaml </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
- auto-tag.yml: fix LATEST fallback using bash parameter expansion (pipe swallows grep exit code, || never fires) - auto-tag.yml: skip gracefully if computed tag already exists - claude-auto-assign.yml: fix bot detection to use correct GitHub App username format (claude[bot] not app/claude) Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v*tags — users can now download binaries without having Go installedmain, bumps semver automatically (feat:→ minor, everything else → patch, breaking → major) and pushes a tag, which then triggers goreleaserclaude-proactive.ymlnow appends@claude please implement thisto every issue it creates — issues were being created but never picked upclaude-auto-assign.ymlnow also triggers forapp/claudebot-created issues (not just org members), and skips if@claudeis already in the body to avoid double-firing@clauderequirement when creating issuesBefore / After
Before: proactive Claude finds bugs → creates issues → issues sit idle forever (auto-assign skips bots, no
@claudein body)After: proactive Claude finds bugs → creates issues with
@claude→ auto-assign fires as backstop → Claude implements → shepherd merges → auto-tag fires → goreleaser publishes binariesTest plan
v0.1.0Summary by CodeRabbit
New Features
Documentation
Chores