fix: write settings.json atomically in hooks.Install#260
Merged
claude[bot] merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
Replace direct os.WriteFile with a temp-file + os.Rename pattern, matching the pattern already used in snapshot.go and activitylog.go. A mid-write crash now leaves the original settings.json intact instead of truncating/corrupting the user's entire Claude Code configuration. Fixes #256 Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: claude[bot] <claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the direct
os.WriteFileinhooks.Installwith an atomic temp-file +os.Renamepattern, consistent with howsnapshot.goandactivitylog.goalready handle writes.Before:
After:
A mid-write crash now leaves the original
settings.jsonintact rather than truncating/corrupting the user's entire Claude Code configuration.Closes #256
Generated with Claude Code