Skip to content

perf(client): build multipart body once before polling loop #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greynewell merged 1 commit into from
Feb 27, 2026
Merged

perf(client): build multipart body once before polling loop #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 38 additions & 33 deletions internal/api/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,23 @@ func (c *Client) GetGraph(ctx context.Context, projectName string, repoZip []byt
idempotencyKey := uuid.NewString()
deadline := time.Now().Add(maxPollDuration)

// Build the multipart body once; reuse it across poll attempts via bytes.NewReader.
var bodyBuf bytes.Buffer
mw := multipart.NewWriter(&bodyBuf)
_ = mw.WriteField("project_name", projectName)
fw, err := mw.CreateFormFile("file", "repo.zip")
if err != nil {
return nil, fmt.Errorf("creating multipart field: %w", err)
}
if _, err := fw.Write(repoZip); err != nil {
return nil, fmt.Errorf("writing zip: %w", err)
}
if err := mw.Close(); err != nil {
return nil, fmt.Errorf("closing multipart: %w", err)
}
bodyBytes := bodyBuf.Bytes()
contentType := mw.FormDataContentType()

for attempt := 0; attempt < maxPollAttempts; attempt++ {
if time.Now().After(deadline) {
return nil, fmt.Errorf("job timed out after %v", maxPollDuration)
Expand All @@ -281,27 +298,12 @@ func (c *Client) GetGraph(ctx context.Context, projectName string, repoZip []byt
default:
}

// Build multipart body on each attempt (re-POST with same idempotency key)
var body bytes.Buffer
mw := multipart.NewWriter(&body)
_ = mw.WriteField("project_name", projectName)
fw, err := mw.CreateFormFile("file", "repo.zip")
if err != nil {
return nil, fmt.Errorf("creating multipart field: %w", err)
}
if _, err := fw.Write(repoZip); err != nil {
return nil, fmt.Errorf("writing zip: %w", err)
}
if err := mw.Close(); err != nil {
return nil, fmt.Errorf("closing multipart: %w", err)
}

req, err := http.NewRequestWithContext(ctx, http.MethodPost,
c.baseURL+"/v1/graphs/supermodel", &body)
c.baseURL+"/v1/graphs/supermodel", bytes.NewReader(bodyBytes))
if err != nil {
return nil, err
}
req.Header.Set("Content-Type", mw.FormDataContentType())
req.Header.Set("Content-Type", contentType)
req.Header.Set("X-Api-Key", c.apiKey)
req.Header.Set("Accept", "application/json")
req.Header.Set("User-Agent", "uncompact/1.0")
Expand Down Expand Up @@ -403,6 +405,23 @@ func (c *Client) GetCircularDependencies(ctx context.Context, projectName string
idempotencyKey := uuid.NewString()
deadline := time.Now().Add(maxPollDuration)

// Build the multipart body once; reuse it across poll attempts via bytes.NewReader.
var bodyBuf bytes.Buffer
mw := multipart.NewWriter(&bodyBuf)
_ = mw.WriteField("project_name", projectName)
fw, err := mw.CreateFormFile("file", "repo.zip")
if err != nil {
return nil, fmt.Errorf("creating multipart field: %w", err)
}
if _, err := fw.Write(repoZip); err != nil {
return nil, fmt.Errorf("writing zip: %w", err)
}
if err := mw.Close(); err != nil {
return nil, fmt.Errorf("closing multipart: %w", err)
}
bodyBytes := bodyBuf.Bytes()
contentType := mw.FormDataContentType()

for attempt := 0; attempt < maxPollAttempts; attempt++ {
if time.Now().After(deadline) {
return nil, fmt.Errorf("circular dependency job timed out after %v", maxPollDuration)
Expand All @@ -413,26 +432,12 @@ func (c *Client) GetCircularDependencies(ctx context.Context, projectName string
default:
}

var body bytes.Buffer
mw := multipart.NewWriter(&body)
_ = mw.WriteField("project_name", projectName)
fw, err := mw.CreateFormFile("file", "repo.zip")
if err != nil {
return nil, fmt.Errorf("creating multipart field: %w", err)
}
if _, err := fw.Write(repoZip); err != nil {
return nil, fmt.Errorf("writing zip: %w", err)
}
if err := mw.Close(); err != nil {
return nil, fmt.Errorf("closing multipart: %w", err)
}

req, err := http.NewRequestWithContext(ctx, http.MethodPost,
c.baseURL+"/v1/graphs/circular-dependencies", &body)
c.baseURL+"/v1/graphs/circular-dependencies", bytes.NewReader(bodyBytes))
if err != nil {
return nil, err
}
req.Header.Set("Content-Type", mw.FormDataContentType())
req.Header.Set("Content-Type", contentType)
req.Header.Set("X-Api-Key", c.apiKey)
req.Header.Set("Accept", "application/json")
req.Header.Set("User-Agent", "uncompact/1.0")
Expand Down