fix: cancel in-flight GetCircularDependencies request when GetGraph fails#80
Merged
claude[bot] merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
…ails Derive a cancellable context at the top of fetchGraphWithCircularDeps and use defer cancel() so that the in-flight HTTP request to the circular- dependencies API endpoint is aborted as soon as GetGraph returns an error, avoiding wasted network bandwidth and API quota. Fixes #78 Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: claude[bot] <claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
GetGraphfails infetchGraphWithCircularDeps, the in-flight HTTP request to the circular-dependencies API endpoint continued running to completion even though its result would be discarded. While there was no goroutine leak (the channel is buffered), this wasted network bandwidth and API quota.Changes
ctx, cancel := context.WithCancel(ctx)anddefer cancel()at the top offetchGraphWithCircularDepsincmd/run.go.GetGraphfails and the function returns early,defer cancel()fires, aborting the in-flightGetCircularDependenciesHTTP request immediately.Fixes #78
Generated with Claude Code