Fix web restore alert missing action button#443
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
onCloseinstead ofaction, so the confirm button was never created and the cancel button opened the URL.LocalizationLogic.localizedBundle()pattern.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.swiftlintin the main directory and fixed any issues.🤖 Generated with Claude Code
Greptile Summary
This PR fixes a critical bug where the web restore alert's trailing closure was binding to
onCloseinstead ofaction, causing the "Yes" button to not appear and the "Cancel" button to incorrectly trigger the restore URL. The fix explicitly names theactionparameter to ensure proper closure binding. Additionally, all alert strings across the SDK have been localized into 41 languages using the existing localization pattern.Key changes:
TransactionManager.swiftby explicitly naming theaction:parameterConfidence Score: 5/5
LocalizationLogic.localizedBundle()) used throughout the codebase. All changes are additive and non-breaking.Important Files Changed
actionparameter, preventing trailing closure from binding toonClose. Localized all alert strings.Last reviewed commit: e79022d