Fix: revoked subscriptions incorrectly reported as active

[yusuftor]

Summary

• When Apple processes a refund, the subscription-level state from StoreKit's subscriptionStatus correctly returns .revoked. However, the SDK was not using this to override the per-transaction isActive check.
• Transaction.all returns the full transaction history. Apple may not set revocationDate on every transaction under the same originalTransactionId, so an unrevoked transaction with a future expirationDate keeps the entitlement active even after a refund.
• This results in state: .revoked but isActive: true on the entitlement — and the user continues to bypass paywalls.

Changes

EntitlementProcessor.swift — In buildEntitlementsWithLiveSubscriptionData, when the live subscription state is .revoked or .expired, override isActive to false instead of carrying forward the first-pass value.

SK2ReceiptManager.swift — After entitlements are resolved, correct Purchase.isActive for any product whose entitlements are all revoked/expired. This flows into AutomaticPurchaseController.syncSubscriptionStatus, which is what actually sets Superwall.shared.subscriptionStatus and gates paywall presentation.

Root cause

The entitlement resolution has two passes:

1. First pass (buildEntitlementsFromTransactions): iterates Transaction.all and sets isActive = true if any transaction has !isRevoked && expirationDate > now
2. Second pass (buildEntitlementsWithLiveSubscriptionData): queries subscriptionStatus for the authoritative subscription-group-level state

The second pass set state from subscriptionStatus but never used it to correct isActive from the first pass. When a refund revokes one transaction but leaves others in the history without revocationDate, the first pass incorrectly computes isActive = true, and the second pass never overrides it.

Test plan

• Verify that a subscription with subscriptionStatus == .revoked correctly results in isActive: false on the entitlement
• Verify that Superwall.shared.subscriptionStatus transitions to .inactive after a refund
• Verify that paywalls are presented to users with revoked subscriptions
• Verify that active (non-revoked) subscriptions are unaffected
• Verify that expired subscriptions are also correctly marked inactive
• Run existing EntitlementProcessorTests to confirm no regressions

🤖 Generated with Claude Code

Greptile Summary

This PR fixes a critical bug where refunded subscriptions were incorrectly reported as active, allowing users to bypass paywalls after receiving a refund.

Root cause: When Apple processes a refund, subscriptionStatus correctly returns .revoked, but Transaction.all may contain transactions without revocationDate set. The first-pass entitlement logic checked individual transactions and incorrectly computed isActive = true, while the second-pass never overrode this value using the authoritative subscription state.

The fix:

• EntitlementProcessor.swift: When subscriptionStatus returns .revoked or .expired, now authoritatively overrides isActive to false
• SK2ReceiptManager.swift: After entitlements are resolved, corrects Purchase.isActive for products where all entitlements are inactive

Key changes:

• Added authoritative state override in the second pass of entitlement resolution
• Included defensive handling for .expired state (redundant but safe)
• Corrects purchase active status based on entitlement-level state
• Well-documented with inline comments explaining the Apple API quirk

The previous review feedback has been addressed: the code now uses isActive directly and includes clarifying comments about the .expired case being defensive.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix is targeted, well-documented, and addresses a specific bug without introducing new complexity. The logic is sound and follows the existing two-pass pattern. Previous review feedback has been incorporated.
• No files require special attention

Important Files Changed

Filename	Overview
Sources/SuperwallKit/StoreKit/Products/Receipt Manager/EntitlementProcessor.swift	Adds authoritative override to force isActive = false when subscription state is .revoked or .expired, fixing the bug where refunded subscriptions stayed active
Sources/SuperwallKit/StoreKit/Products/Receipt Manager/Receipt Manager/SK2ReceiptManager.swift	Corrects Purchase.isActive based on entitlement state after resolution, ensuring purchases are marked inactive when all entitlements are revoked/expired

_{Last reviewed commit: 5650528}

[greptile-apps]

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}