Skip to content

Bug fix renovate for github #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fpintoppb merged 1 commit into from
Mar 21, 2025
Merged

Bug fix renovate for github #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions surface/sca/management/commands/renovate_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def handle(self, *args, **options):
platform = platforms.pop()
repo_urls = [self.parse_git_url(url)[1] for url in git_urls]

temp_config_path = self.create_temp_renovate_config(repo_urls, dependencies, is_local)
temp_config_path = self.create_temp_renovate_config(repo_urls, dependencies, is_local, platform)
try:
result = self.run_docker(platform, temp_config_path, is_local)
if not result:
Expand All @@ -46,7 +46,7 @@ def parse_git_url(self, git_url: str):
repo_path = "/".join(repo_url.split("/")[1:])
return platform, repo_path

def create_temp_renovate_config(self, repo_urls: list, dependencies=None, is_local=False):
def create_temp_renovate_config(self, repo_urls: list, dependencies=None, is_local=False, platform=None):
if dependencies is None:
dependencies = []
current_script_dir = Path(__file__).parent
Expand All @@ -70,9 +70,12 @@ def create_temp_renovate_config(self, repo_urls: list, dependencies=None, is_loc
else:
raise ValueError("Dependencies must be a list or a string")

sorted_dependencies = sorted(unique_dependencies)
dep_pattern = f"^(?i)({'|'.join(sorted_dependencies)})$"
config["packageRules"][1]["matchPackagePatterns"] = [dep_pattern]
if unique_dependencies:
sorted_dependencies = sorted(unique_dependencies)
dep_pattern = f"^(?i)({'|'.join(sorted_dependencies)})$"
config["packageRules"][1]["matchPackagePatterns"] = [dep_pattern]
if platform == "github":
config["prTitle"] = "Update vulnerable dependencies"

timestamp = datetime.now().strftime("%Y%m%d%H%M%S")
temp_file_path = Path("/renovate") / f"renovate_config_{timestamp}.json"
Expand Down
3 changes: 2 additions & 1 deletion surface/sca/tests/expected_renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@
"enabled": true
}
],
"prHourlyLimit": 0
"prHourlyLimit": 0,
"prTitle": "Update vulnerable dependencies"
}