Skip to content

chore: bump versions to 0.12.4 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sv2dev merged 1 commit into from
Apr 2, 2026
Merged

chore: bump versions to 0.12.4 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/esroute-lit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@esroute/lit",
"version": "0.12.3",
"version": "0.12.4",
"description": "A small efficient client-side routing library for lit, written in TypeScript.",
"type": "module",
"types": "dist/index.d.ts",
Expand All @@ -11,6 +11,7 @@
"default": "./dist/index.js"
}
},
"files": ["dist", "LICENSE", "README.md"],
"sideEffects": false,
"license": "MIT",
"author": "Sven Rogge <mail@sven-rogge.com>",
Expand Down
3 changes: 2 additions & 1 deletion packages/esroute/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "esroute",
"version": "0.12.3",
"version": "0.12.4",
"description": "A small efficient framework-agnostic client-side routing library, written in TypeScript.",
"type": "module",
"types": "dist/index.d.ts",
Expand All @@ -11,6 +11,7 @@
"default": "./dist/index.js"
}
},
"files": ["dist", "LICENSE", "README.md"],
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

cd packages/esroute
echo "Checking manifest-declared files..."
for f in dist LICENSE README.md; do
  if [ -e "$f" ]; then
    echo "OK: $f"
  else
    echo "MISSING: $f"
  fi
done

echo
echo "npm pack dry-run file list:"
npm pack --dry-run

Repository: sv2dev/esroute

Length of output: 698

dist directory is missing from filesystem but declared in files array.

The dist directory specified in the "files" field doesn't exist in packages/esroute/. Current npm pack output includes only LICENSE and README.md (plus package.json). Either build the dist directory or remove it from the files array.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/esroute/package.json` at line 14, The package.json "files" array
lists "dist" but the dist directory is not present; either generate the build
output or remove the entry. Fix by updating the packages/esroute/package.json
"files" array to remove "dist" if you don't intend to publish built artifacts,
or ensure the build step (e.g., the project’s build script that outputs into
packages/esroute/dist) runs and produces the dist folder before publishing;
verify the chosen approach by running npm pack to confirm the dist folder is
included or the files array no longer references it.

"sideEffects": false,
"license": "MIT",
"author": "Sven Rogge <mail@sven-rogge.com>",
Expand Down
1 change: 0 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"moduleDetection": "force",
"moduleResolution": "node16",
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"strict": true,
"skipLibCheck": true
Expand Down
Loading