Skip to content

Conversation

@manuel3108
Copy link
Member

Closes #828
Relates #839

moves all html related stuff to using the svelte parser and printer.
removed the createDiv function and according test. Why did we even had that, it's totally useless since you can just createElement('div')

There is one failing test.
<!doctype html /> -- needs another pr to svelte.
<html lang="en" lang="%paraglide.lang%"> -- where the heck is the duplicated lang attribute coming from? I guess it's from the paraglide addon and should always have been there, but it wasn't. Why though? Actually that cant be the case. Is it coming from svelte as well? Will need to check

Will need to check tomorrow, it's getting late.
image

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: 443b118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@840
npx https://pkg.pr.new/sveltejs/cli/sv@840

commit: 443b118

@manuel3108
Copy link
Member Author

manuel3108 commented Dec 10, 2025

Once sveltejs/svelte#17341 is merged, feel free to update and review here. I don't think there should be anything else to do here.

@jycouet jycouet marked this pull request as ready for review December 11, 2025 20:55
@jycouet jycouet merged commit f5572e5 into main Dec 11, 2025
8 checks passed
@jycouet jycouet deleted the chore/drop-deps-html branch December 11, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reduce dependency count

3 participants