`throw error(204)` returns invalid response

[benmccann]

Describe the bug

Undici is fails to fetch an endpoint which returns throw error(204) because it expects there to be no body. Users cannot currently save in the REPL as a result

Reproduction

https://github.com/sveltejs/sites/blob/9c15c79b4bcdf043166b4b3974576e86bb783289/sites/svelte.dev/src/routes/(authed)/repl/%5Bid%5D.json/%2Bserver.js#L98

Logs

No response

System Info

`master`

Severity

blocking an upgrade

Additional Information

No response

[Rich-Harris]

throw error(204) makes no sense — a 204 response isn't an error. That line should be changed to this:

return new Response(undefined, { status: 204 });

We should disallow error codes below 400.

[zharsing]

Hey Rich, what's the deal with this?

if I do the following in a GET in a +server.js

return new Response(undefined, { status: 204 });

it results the following in my log on a node server:

TypeError: Cannot set property status of #<_Response> which has only a getter

[Rich-Harris]

Please open a new issue instead of commenting on closed ones — it's pure happenstance that I saw this

[zharsing]

not my issue mate ..

[Rich-Harris]

Up to you. If you open a new issue, there's a chance it will get fixed. If you don't, then 🤷