fix: consistently use bare import for internals#14506
Merged
dummdidumm merged 1 commit intomainfrom Sep 22, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 6467e0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
(Tested the repro in #14505 with the pkg.pr.new version from this PR, and it does indeed appear to be fixed) |
dominikg
approved these changes
Sep 22, 2025
Merged
dummdidumm
added a commit
that referenced
this pull request
Sep 22, 2025
… src/runtime So that bugs that e.g. #14506 had to fix don't happen again
teemingc
reviewed
Sep 23, 2025
| @@ -1,6 +1,6 @@ | |||
| import { base, assets, relative } from './internal/server.js'; | |||
Member
There was a problem hiding this comment.
What's the reason for this import not using the import map $apps/paths/internal/server instead? Does the rule only apply to internal paths using the export map?
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
… src/runtime (sveltejs#14510) So that bugs that e.g. sveltejs#14506 had to fix don't happen again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #14447 I broke a cardinal rule — code in
src/runtimeshould only ever import code fromsrc/exportsvia the public bare imports made available viapkg.exports. Otherwise, there's a danger that a given module will be loaded through both Vite and Node, causing breakage.I ignored that rule because I was trying to deal with some tricky resolution bug, and #14505 was my reward. Luckily I think the tricky resolution bug is solved by not having a nested
pkg.exportsmap, and instead abusingpkg.importsto achieve the intended outcome.This is one of those things that's extremely hard to test for from within the workspace, because of how Vite works. But I think this solution is good. Closes #14505.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits