fix: decrement pending_count when form callback doesn't call submit() by AndreasHald · Pull Request #15520 · sveltejs/kit

AndreasHald · 2026-03-09T11:27:02Z

This PR proposes a solution to the fact that a remote form does not reset pending count if the enhance function does not call the submit function

Alternative solutions

Move the pending count reset out of the submit function, this could possibly be a better solution since it's less code but I didn't have enough of an understanding of the code to fully grasp the consequences and I believe this change is easy enough to understand.
Don't reset at all, it could be that to dissuade consumers from not calling the submit function this was done intentionally however I don't think this is the case.
Only increment after submit has been called. I think this is a bad solution for 2 reasons. 1) submit is async and we'd probably wan't to show pending while it's doing something and 2) fix: increment form.pending count before preflight validation #15279 explicitly moved it earlier.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

changeset-bot · 2026-03-09T11:27:07Z

🦋 Changeset detected

Latest commit: 03827f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

svelte-docs-bot · 2026-03-09T11:30:11Z

Preview: https://svelte-dev-git-preview-kit-15520-svelte.vercel.app/

sillvva · 2026-03-16T19:07:51Z

I think the better solution is to move the pending_count-- from the submit function to the handle_submit function where it is incremented in the first place. It should be decremented regardless of the result of the callback. Then if the submit() method isn't called or the enhance callback throws, it will not prevent the pending count from being reset.

An easy enough way to understand if there are consequences to this is to just try it and run the tests, but I am pretty confident that the pending count would still work properly this way.

AndreasHald · 2026-03-18T07:07:47Z

@sillvva like this? it's quite a bit simpler.

sillvva · 2026-03-18T12:50:43Z

Yep! Exactly what I had in mind. Decrementing it in the same place it is incremented ensures it always stays in sync.

paoloricciuti · 2026-03-25T17:01:48Z

Sorry didn't realize this was already open and I've opened #15602 ...however this PR is decreasing pending_count every time (also when submit is invoked) which means it actually introduces a bug. That and the fact that it doesn't have a test means we will likely merge #15602

Thanks for contributing anyway! 🧡

paoloricciuti · 2026-03-25T17:04:16Z

Actually I was wrong lol I misread the fix and this is actually better (except the test)...I'm gonna add the test here and merge this

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.56.0 ### Minor Changes - breaking: rework client-driven refreshes ([#15562](#15562)) - breaking: stabilize remote function caching by sorting object keys ([#15570](#15570)) - breaking: add `run()` method to queries, disallow awaiting queries outside render ([#15533](#15533)) - feat: support TypeScript 6.0 ([#15595](#15595)) - breaking: isolate command-triggered query refresh failures per-query ([#15562](#15562)) - feat: use `hydratable` for remote function transport ([#15533](#15533)) - feat: allow `form` fields to specify a default value (`field.as(type, value)`) ([#15577](#15577)) ### Patch Changes - fix: don't request new data when `.refresh` is called on a query with no cache entry ([#15533](#15533)) - fix: allow using multiple remote functions within one async derived ([#15561](#15561)) - fix: avoid false-positive overridden Vite `base` setting warning when setting a `paths.base` in `svelte.config.js` ([#15623](#15623)) - fix: manage queries in their own `$effect.root` ([#15533](#15533)) - fix: avoid `inlineDynamicImports` deprecation warning when building the service worker with Vite 8 ([#15550](#15550)) - fix: correctly escape backticks when precomputing CSS ([#15593](#15593)) - fix: discard obsolete forks before finishing navigation ([#15634](#15634)) - chore: tighten up override implementation ([#15562](#15562)) - fix: ensure the default Svelte 5 `error.svelte` file uses runes mode ([#15609](#15609)) - fix: deduplicate same-cache-key `batch` calls during SSR ([#15533](#15533)) - fix: decrement pending_count when form callback doesn't call submit() ([#15520](#15520)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@sveltejs/kit](https://svelte.dev) ([source](https://github.com/sveltejs/kit/tree/HEAD/packages/kit)) | [`2.55.0` → `2.56.1`](https://renovatebot.com/diffs/npm/@sveltejs%2fkit/2.55.0/2.56.1) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@sveltejs%2fkit/2.56.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@sveltejs%2fkit/2.55.0/2.56.1?slim=true) | --- ### Release Notes <details> <summary>sveltejs/kit (@sveltejs/kit)</summary> ### [`v2.56.1`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#2561) [Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@2.56.0...@sveltejs/kit@2.56.1) ##### Patch Changes - chore: update JSDoc ([#15640](sveltejs/kit#15640)) ### [`v2.56.0`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#2560) [Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@2.55.0...@sveltejs/kit@2.56.0) ##### Minor Changes - breaking: rework client-driven refreshes ([#15562](sveltejs/kit#15562)) - breaking: stabilize remote function caching by sorting object keys ([#15570](sveltejs/kit#15570)) - breaking: add `run()` method to queries, disallow awaiting queries outside render ([#15533](sveltejs/kit#15533)) - feat: support TypeScript 6.0 ([#15595](sveltejs/kit#15595)) - breaking: isolate command-triggered query refresh failures per-query ([#15562](sveltejs/kit#15562)) - feat: use `hydratable` for remote function transport ([#15533](sveltejs/kit#15533)) - feat: allow `form` fields to specify a default value (`field.as(type, value)`) ([#15577](sveltejs/kit#15577)) ##### Patch Changes - fix: don't request new data when `.refresh` is called on a query with no cache entry ([#15533](sveltejs/kit#15533)) - fix: allow using multiple remote functions within one async derived ([#15561](sveltejs/kit#15561)) - fix: avoid false-positive overridden Vite `base` setting warning when setting a `paths.base` in `svelte.config.js` ([#15623](sveltejs/kit#15623)) - fix: manage queries in their own `$effect.root` ([#15533](sveltejs/kit#15533)) - fix: avoid `inlineDynamicImports` deprecation warning when building the service worker with Vite 8 ([#15550](sveltejs/kit#15550)) - fix: correctly escape backticks when precomputing CSS ([#15593](sveltejs/kit#15593)) - fix: discard obsolete forks before finishing navigation ([#15634](sveltejs/kit#15634)) - chore: tighten up override implementation ([#15562](sveltejs/kit#15562)) - fix: ensure the default Svelte 5 `error.svelte` file uses runes mode ([#15609](sveltejs/kit#15609)) - fix: deduplicate same-cache-key `batch` calls during SSR ([#15533](sveltejs/kit#15533)) - fix: decrement pending\_count when form callback doesn't call submit() ([#15520](sveltejs/kit#15520)) </details> --- ### Configuration 📅 **Schedule**: (in timezone UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/ampmod/aw3/pulls/57 Co-authored-by: AmpMod Bot <ampmod-bot@noreply.codeberg.org> Co-committed-by: AmpMod Bot <ampmod-bot@noreply.codeberg.org>

teemingc added the forms Stuff relating to forms and form actions label Mar 18, 2026

AndreasHald added 3 commits March 18, 2026 08:06

fix: decrement pending_count when form callback doesn't call submit()

44d4c5c

add changeset

537c83b

Changes request by sillvva

d001fd1

AndreasHald force-pushed the fix-form-pending-count branch from 3b94b3d to d001fd1 Compare March 18, 2026 07:06

paoloricciuti closed this Mar 25, 2026

paoloricciuti reopened this Mar 25, 2026

paoloricciuti added 2 commits March 25, 2026 18:05

Merge branch 'main' into fix-form-pending-count

90870f9

chore: add test

54c39c9

paoloricciuti changed the title ~~Fix form pending count~~ fix: decrement pending_count when form callback doesn't call submit() Mar 25, 2026

paoloricciuti mentioned this pull request Mar 25, 2026

fix: reduce pending count even if form with enhance was never submitted #15602

Closed

fix: duh wrong test

03827f1

paoloricciuti approved these changes Mar 25, 2026

View reviewed changes

paoloricciuti merged commit 2fb1334 into sveltejs:main Mar 25, 2026
25 checks passed

This was referenced Mar 24, 2026

Version Packages #15552

Merged

Version Packages (next) #15311

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: decrement pending_count when form callback doesn't call submit()#15520

fix: decrement pending_count when form callback doesn't call submit()#15520
paoloricciuti merged 6 commits into
sveltejs:mainfrom
AndreasHald:fix-form-pending-count

AndreasHald commented Mar 9, 2026

Uh oh!

changeset-bot Bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

svelte-docs-bot Bot commented Mar 9, 2026

Uh oh!

sillvva commented Mar 16, 2026 •

edited

Loading

Uh oh!

AndreasHald commented Mar 18, 2026

Uh oh!

sillvva commented Mar 18, 2026

Uh oh!

paoloricciuti commented Mar 25, 2026

Uh oh!

paoloricciuti commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

AndreasHald commented Mar 9, 2026

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

Uh oh!

changeset-bot Bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

svelte-docs-bot Bot commented Mar 9, 2026

Uh oh!

sillvva commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndreasHald commented Mar 18, 2026

Uh oh!

sillvva commented Mar 18, 2026

Uh oh!

paoloricciuti commented Mar 25, 2026

Uh oh!

paoloricciuti commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Mar 9, 2026 •

edited

Loading

sillvva commented Mar 16, 2026 •

edited

Loading