[chore] Make rawBody be the bytes#2215
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: bedda81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Aug 17, 2021
Member
Rich-Harris
left a comment
There was a problem hiding this comment.
thank you! i may not have fully understood everything, but it feels like we can simplify even further? comments inline
Rich-Harris
reviewed
Aug 17, 2021
Member
Rich-Harris
left a comment
There was a problem hiding this comment.
thanks for those changes. i had one final question (see comments) then i think this is probably good to go
ignatiusmb
reviewed
Aug 17, 2021
Member
|
this change is a huge improvement — thank you! |
This was referenced Aug 17, 2021
This was referenced Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0Closes #1893 by ensuring
rawBodyis anUint8Arraybefore it is passed down to request handlers.