Legacy builds

[dishuostec]

This PR use a monkey patched version of @vitejs/plugin-legacy.

Here is a forked hn.svelte.dev with legacy builds.

It works, but I don't know why the order of nodes are wrong.

*Some tests*

TODO:

• test in IE 11.
• test in Safari 10.1.
• resolve wrong order of DOM nodes.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0d88f09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dominikg]

there are issues covering legacy builds already #12 and #2745

Your PR adds an experimental monkey-patched version of vite-plugin-legacy as a dependency, which is not likely to get merged.

I suggest you mark it as a draft and join us on discord to discuss how legacy support can be achieved as an optional addon instead of a hard dependency.

[benmccann]

I'd agree with Dominik that the best course of action would be to get any necessary improvements into vite-plugin-legacy as a first course of action

[dishuostec]

Ok, I will make a PR to vite-plugin-legacy to try to make it works with kit.

[benmccann]

I'm going to close this for the time being to keep the review queue clean. We can reopen after vite-plugin-legacy has been updated