Merged
Conversation
|
dummdidumm
approved these changes
Feb 19, 2022
Member
dummdidumm
left a comment
There was a problem hiding this comment.
Agree with this change. The files are not that huge that it gets out of hand and I also often wasn't sure what goes where
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation behind this is an idea I had about documenting types (#4002), but I think it's valuable in its own right so I'm opening this separately from any docs changes.
Right now we have types scattered amongst a bunch of nebulously-scoped
.d.tsfiles. It would be much simpler all round if we just split the types into public (index.d.ts), private (internal.d.ts) and ambient (ambient.d.ts). I don't think the current setup serves any real purpose.I haven't made any changes to the types themselves — just where they live — but I do think there's a worthwhile conversation to be had about where we draw the line between public and private. There's definitely some things in
internal.d.tsthat wouldn't be terribly out of place inindex.d.ts. I don't think we need to solve that in this PR though.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0