Merged
Conversation
🦋 Changeset detectedLatest commit: 800476b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Mar 3, 2022
benmccann
reviewed
Mar 3, 2022
Member
|
Is this command cheap enough that we can run it whenever we want to run |
Member
Author
|
For a large-ish app it takes about 100ms on my machine — it's basically free |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
indaco
added a commit
to sveltinio/sveltin
that referenced
this pull request
Mar 7, 2022
With [#4182](sveltejs/kit#4182), SvelteKit added support for a new CLI command called `sync` wrapped as `prepare` script in `package.json` file
indaco
added a commit
to sveltinio/sveltin
that referenced
this pull request
Mar 7, 2022
- it command wraps the new SvelteKit `sync` command, [#4182](sveltejs/kit#4182) - package.json files updated to include the new "prepare" script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4165. This adds a
syncmodule responsible for writing stuff tooutDir—generated/manifest.js,generated/root.svelte,runtime,typesandtsconfig.json.It also adds a
svelte-kit synccommand that runs when you first set up a new project, to ensure that types are set up and correct before you run typechecking.I've been meaning to tidy up this corner of the codebase anyway, and this was a nice opportunity to do it.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0