Should fix 4177 navigation to pages with iframe with relative urls are broken#4191
Should fix 4177 navigation to pages with iframe with relative urls are broken#4191Rich-Harris merged 3 commits intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 7306d28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks — can you add a test please? |
|
@Rich-Harris But actually I think this PR may make tests more flaky(and that is the reason we did #4070), is there any way to solve this without doing |
|
Since the DOM update happens in the same turn of the event loop as |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0Fixes #4177
I just did what @Rich-Harris wrote in #4177 (comment) that should fix it.