Ensure props are loaded from matching endpoint during client-side navigation#4203
Merged
Rich-Harris merged 4 commits intomasterfrom Mar 4, 2022
Merged
Ensure props are loaded from matching endpoint during client-side navigation#4203Rich-Harris merged 4 commits intomasterfrom
Rich-Harris merged 4 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: b5aa291 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
benmccann
reviewed
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4038.
Credit to @aolose for the first version of this (#4139). I tried to work on that branch but things had diverged too much, and I was concerned that the implementation came with fair bit of intrinsic complexity. This implementation is slightly less sophisticated — if an endpoint falls through during client-side navigation, Kit won't find which endpoint actually matches and allow the client to short-circuit the next attempt — but it's less code and easier to follow. Fallthroughs are something of an edge case so I'm okay with them not being fully optimised.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0