allow InputProps and OutputProps to be typed in generated Load#4305
Merged
Rich-Harris merged 10 commits intosveltejs:masterfrom Mar 14, 2022
Merged
allow InputProps and OutputProps to be typed in generated Load#4305Rich-Harris merged 10 commits intosveltejs:masterfrom
InputProps and OutputProps to be typed in generated Load#4305Rich-Harris merged 10 commits intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 2d367e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
I also have noticed the same issue with the generated I'm not sure what to do with the |
d609bb1 to
2d367e7
Compare
Member
|
Thanks! Yeah, it makes sense to expose |
Rich-Harris
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0Same fix as here: #4160
But this time for the generated
Loadtype.I also have restricted all the
ParamsandPropstypes with theextendskeyword.Maybe it makes sense to create a "base type" and use it everywhere: