Convert adapter-cloudflare back to JS#4474
Merged
Rich-Harris merged 1 commit intochore/cloudflare-worktopfrom Mar 31, 2022
Merged
Convert adapter-cloudflare back to JS#4474Rich-Harris merged 1 commit intochore/cloudflare-worktopfrom
Rich-Harris merged 1 commit intochore/cloudflare-worktopfrom
Conversation
|
lukeed
approved these changes
Mar 31, 2022
Member
lukeed
left a comment
lukeed
left a comment
There was a problem hiding this comment.
Personally would prefer a @typedef to break out some of the long-running type info, but as long as the type check is happy then I'm fine
lukeed
reviewed
Mar 31, 2022
| const prefix = `/${manifest.appDir}/`; | ||
|
|
||
| const worker: Module.Worker<Environment> = { | ||
| /** @type {import('worktop/cfw').Module.Worker<{ ASSETS: import('worktop/cfw.durable').Durable.Object }>} */ |
Member
There was a problem hiding this comment.
Optional, free to disregard
Suggested change
| /** @type {import('worktop/cfw').Module.Worker<{ ASSETS: import('worktop/cfw.durable').Durable.Object }>} */ | |
| /** | |
| * @typedef Environment | |
| * @property {import('worktop/cfw.durable').Durable.Object} ASSETS | |
| */ | |
| /** @type {import('worktop/cfw').Module.Worker<Environment>} */ |
Rich-Harris
added a commit
that referenced
this pull request
Mar 31, 2022
* chore(cloudflare): optimize Cache usage; strict TS source * chore: add changeset * skip lib check for conflicts * bundle worktop (#4473) * bundle worktop * build on prepublishOnly * Update packages/adapter-cloudflare/tsconfig.json * update builder file paths Co-authored-by: Luke Edwards <luke.edwards05@gmail.com> * convert to JS (#4474) * Update .changeset/empty-falcons-run.md Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i think this gives us the same level of type safety