Skip to content

apply linking logic to inline code spans#4475

Merged
Rich-Harris merged 1 commit intomasterfrom
link-inline-codespans
Apr 1, 2022
Merged

apply linking logic to inline code spans#4475
Rich-Harris merged 1 commit intomasterfrom
link-inline-codespans

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

@Rich-Harris Rich-Harris commented Mar 31, 2022

This is a possible solution to #4445 — it makes references to types in inline <code> spans link to their definitions, and updates the RequestHandler type accordingly:

image

This seems more scalable/less invasive than the alternative, to me

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2022

⚠️ No Changeset found

Latest commit: 52d325c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request Mar 31, 2022
5 tasks
* HTTP verb (`get`, `put`, `patch`, etc) and handles requests with
* that method. Note that since 'delete' is a reserved word in
* JavaScript, delete handles are called `del` instead.
* A `(event: RequestEvent) => RequestHandlerOutput` function exported from an endpoint that corresponds to an HTTP verb (`get`, `put`, `patch`, etc) and handles requests with that method. Note that since 'delete' is a reserved word in JavaScript, delete handles are called `del` instead.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make a similar change to the description of Load to make it easier to read sans generics as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can, i just figured we should get the plumbing in first and then make the actual changes separately (apart from this one for demo purposes) rather than worrying about all the content changes straight away

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the only other one we might consider to changing from a quick skim though I did earlier, so figured we might as well just get it out of the way. Anyway, this change looks good to me

@Rich-Harris Rich-Harris merged commit aa2e2c4 into master Apr 1, 2022
@Rich-Harris Rich-Harris deleted the link-inline-codespans branch April 1, 2022 19:55
@Rich-Harris Rich-Harris mentioned this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants