feat: Merge ErrorLoad and Load, make Input and Output typings public#4515
Merged
Rich-Harris merged 7 commits intosveltejs:masterfrom Apr 14, 2022
Conversation
- Moved LoadInput and LoadOutput from private.d.ts to public.d.ts - Combined definitions of ErrorLoad and Load - Combined definitions of ErrorLoadInput and LoadInput - Updated references to old ErrorXxx types - Added boilerplate to make status and error props null in the default case
🦋 Changeset detectedLatest commit: b34fa52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 7, 2022
Rich-Harris
reviewed
Apr 14, 2022
Rich-Harris
approved these changes
Apr 14, 2022
Member
|
Thank you! |
5 tasks
Rich-Harris
pushed a commit
that referenced
this pull request
Apr 18, 2022
ErrorLoad merged into Load. #4515
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged the declarations of
ErrorLoadandLoadand their corresponding input typesErrorLoadInputandLoadInput. Moved theLoadInputandLoadOutputinterfaces toindex.d.tsfromprivate.d.ts.No behaviors have actually been changed, but the
statusanderrorproperties are now part of the official public API.See issue #4461 for discussion.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkOne test is failing for me locally, but it is also failing onmasterChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0