apply set-cookie headers from page dependencies#4588
Merged
Rich-Harris merged 9 commits intomasterfrom Apr 15, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: c8f71e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Apr 14, 2022
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1198.
set-cookieheaders from endpoints were being handled in a fairly naive way — if the response was read insideload, theset-cookieheaders were merged with existing ones, but otherwise they were ignored.With this PR,
set-cookieheaders are automatically parsed (not just if the response is read) using set-cookie-parser (which doesn't mind if multiple headers have been concatenated), and kept track of asloadruns. This means that if two endpoints arefetched inload, cookies from the first response will be applied to the second request, and cookies from both responses are added to the page response.Very possible that I've overlooked some nuance around domains or somesuch, so would be grateful for a sanity check.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0