update generated tsconfig#4791
Merged
Rich-Harris merged 5 commits intosveltejs:masterfrom May 4, 2022
ghostdevv:fix-package
Merged
update generated tsconfig#4791Rich-Harris merged 5 commits intosveltejs:masterfrom ghostdevv:fix-package
Rich-Harris merged 5 commits intosveltejs:masterfrom
ghostdevv:fix-package
Conversation
🦋 Changeset detectedLatest commit: 2d3bd52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Maybe we should be using |
Member
Author
|
Good idea, have switched to that |
Rich-Harris
reviewed
May 4, 2022
Rich-Harris
approved these changes
May 4, 2022
Member
|
Thanks, this seems like the right fix to me |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0It's probably best to discuss the side effects of this change, it fixes my issue of #4460 and also #4764 - However this was changed in #4633 and maybe this change is what should stay and alternative solution to the issues can be done such as what I proposed here #4460 (comment)