[fix] Use vite preview port in templates for playwright config#5433
Merged
Rich-Harris merged 9 commits intosveltejs:masterfrom Jul 8, 2022
philip-weber:align-playwright-port-with-vite-preview-server
Merged
[fix] Use vite preview port in templates for playwright config#5433Rich-Harris merged 9 commits intosveltejs:masterfrom philip-weber:align-playwright-port-with-vite-preview-server
Rich-Harris merged 9 commits intosveltejs:masterfrom
philip-weber:align-playwright-port-with-vite-preview-server
Conversation
|
Rich-Harris
reviewed
Jul 8, 2022
Member
Rich-Harris
left a comment
There was a problem hiding this comment.
Thanks! A few suggestions
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Contributor
Author
|
Thank you for your suggestions. |
Rich-Harris
approved these changes
Jul 8, 2022
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5429 which was introduced with #5392.
I have changed the web server port from 3000 to 4173 in the
playwright.config.jstemplates to be in line with the preview server ports fromvite.I am not totally sure if the changes to the tests are good enough. But if the
viteports will change in the future the tests should be failing.I am also not quite sure if my selections for the changeset are correct.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0