Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-news-shout.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Return a 303 response when a `POST` handler provides a `location`
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/page/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export async function render_page(event, route, options, state, resolve_opts) {
}

if (event.request.method === 'POST' && result?.location) {
return redirect_response(status, result.location);
return redirect_response(303, result.location);
}
} else {
event.setHeaders({
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export function POST() {
return {
location: '/shadowed/post-success-redirect/redirected'
};
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<form method="POST">
<button>Click me</button>
</form>
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<h1>POST was successful</h1>
6 changes: 6 additions & 0 deletions packages/kit/test/apps/basics/test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,12 @@ test.describe('Shadowed pages', () => {
);
});

test('Handles POST success with returned location', async ({ page }) => {
await page.goto('/shadowed/post-success-redirect');
await Promise.all([page.waitForNavigation(), page.click('button')]);
expect(await page.textContent('h1')).toBe('POST was successful');
});

test('Renders error page for 4xx and 5xx responses from GET', async ({ page, clicknav }) => {
await page.goto('/shadowed');
await clicknav('[href="/shadowed/error-get"]');
Expand Down