prefer JSON error responses over HTML in fetch case#6497
Merged
dummdidumm merged 3 commits intomasterfrom Sep 1, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 39df1b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Conduitry
reviewed
Aug 31, 2022
Member
Author
|
Marked this as draft because https://github.com/sveltejs/kit/pull/6497/files#diff-964f525b2136e97820d0ba82ceb5c6ab8d7a38c365fe198cfe855910500972cfR182 is unforgivable. Need to come up with some unambiguous way to communicate error information in a way that's comprehensible to both SvelteKit and users |
Member
Author
|
Ok, I have an idea for what to do about errors more broadly, but I think it falls out of the scope of this PR, so I'm marking it as ready again |
dummdidumm
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1931.
Today, if you have a route like this...
...then visiting
/errorwill show you the fallback error page:If you
fetchthe page with anapplication/jsonheader, you'll get a JSON representation of the error......but by default
fetchwill get HTML. In most cases that's probably not that helpful.This PR reverses the precedence during content negotiation, so that if a request has an
accept: */*header (whichfetchrequests do, by default) it will prefer JSON to HTML.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0